On 2013/04/12 10:00, Mark <m...@iinet.net.au> wrote: > Passes 3 environment variables (channels, bits, rate) to stdout > for use by the next process in the pipe (eg SoX). > > Please pull: > > git://git.musicpd.org/quad/mpd.git master
Identation uses spaces instead of tabs, please fix. Why these variables, why not string literals? Using buffers adds unnecessary overhead, because each call allocates space on the stack and copies the string literal there. + char rate_str[]="rate"; Also, your code sets environment variables in the MPD process, but this should better be limited to the new child process only. ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
