I recently opened a bug: http://bugs.musicpd.org/view.php?id=3787

The main problem is that opus encoder config for signal overwrote bitrate
setting. Appended patch fixes that.

Remaining problem: Different settings and semantics of settings for different
encoders, none of it really documented...

---
 src/encoder/OpusEncoderPlugin.cxx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/encoder/OpusEncoderPlugin.cxx
b/src/encoder/OpusEncoderPlugin.cxx index 8d2c097..7167473 100644
--- a/src/encoder/OpusEncoderPlugin.cxx
+++ b/src/encoder/OpusEncoderPlugin.cxx
@@ -106,11 +106,11 @@ opus_encoder_configure(struct opus_encoder *encoder,
 
        value = config_get_block_string(param, "signal", "auto");
        if (strcmp(value, "auto") == 0)
-               encoder->bitrate = OPUS_AUTO;
+               encoder->signal = OPUS_AUTO;
        else if (strcmp(value, "voice") == 0)
-               encoder->bitrate = OPUS_SIGNAL_VOICE;
+               encoder->signal = OPUS_SIGNAL_VOICE;
        else if (strcmp(value, "music") == 0)
-               encoder->bitrate = OPUS_SIGNAL_MUSIC;
+               encoder->signal = OPUS_SIGNAL_MUSIC;
        else {
                g_set_error(error_r, opus_encoder_quark(), 0,
                            "Invalid signal");
-- 
1.8.3.1


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to