On Wed, 05 Dec, 2012 at 21:51:54 GMT, Ben Boeckel wrote:
> I bisected the repository to find out when this broke and ended up with
> a commit from Feb 2010[2], specifically where replay gain was removed
> from the core decoder codepath and added as a filter. Hooking up the
> replay_gain filter does not put the tags back into the stream.

<snip>

> [2]commit 752dfb3d95482c562e5d24c6ea839c4815de9a6d

So I'm back on the case for this one. Latest master still has the
problem and the newest commit that the patch that was attached is from
January[1] and applying it there brings back the tags. I'd be willing to
admit that it might be a problem in ffmpeg's ogg code since it is
apparently not the easiest to deal with[2], but I figure some input from
the MPD side of things would be helpful.

As a thought, I tried latest master without any replaygain features
enabled and the tags still didn't show up, so it isn't just that :/ .

Thanks,

--Ben

[1]3bbb5023871aaba48b6f503dd53d864f9a44c07d
[2]23:55 < fflogger> [newticket] mathstuf: Ticket #3043 (RFE: Implement
updated comment header packets in OGG/vorbis streams) created
https://trac.ffmpeg.org/ticket/3043
00:18 <@Compn> mathstuf : just want to warn you, many developers have
tried to work on ogg, but gave up :)


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to