On 13 January 2014 22:04, Andrée Ekroth <andree.ekr...@gmail.com> wrote:
> On 13 January 2014 21:58, Max Kellermann <m...@duempel.org> wrote:
>
>> On 2014/01/13 21:52, Andrée Ekroth <andree.ekr...@gmail.com> wrote:
>> > Hello,
>> > - I have removed the unnecessary buffer we talked about in the
>> > IRC.
>>
>> Merged.
>>
>> > - I also found a bug in the shine library which I added a workaround
>> for.
>> > Basically the encoder can't initialize until MPD calls write the
>> first
>> > time, or else it results in a segmentation fault.
>>
>> Hm, I don't like how you did this. This bug is unfortunate, but your
>> workaround complicates the code.
>>
>> Another idea: if nothing was written, the "close" method shall write
>> zeroes. The advantage is that the workaround lives only inside the
>> "close" method, and there's no initialization postponed to the "write"
>> method.
>>
>
> That should work, I'll look into that.
>
>
>>
>> Note that this commit introduces a compiler warning because the
>> "error" parameter is now unused. I always configure with
>> "--enable-werror", please do the same.
>
>
> Yup, noticed it the very second I got your response.
>
>
>>
>> When you find a typo in your commit, don't write a new commit - amend
>> the existing one. (Given that the wrong commit was not yet merged.)
>
>
> Right, I'll keep this in mind.
>
Hello again,
Workaround fixed. Writing zeroes worked and was a much simpler solution.
git pull g...@github.com:ekroth/mpd.git shine
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
