On Fri, Dec 21, 2012 at 02:18:46AM +0100, Matthias Andree wrote:
Regarding the other patch, you seem to have merged most of it, but not the switch from AC_GNU_SOURCE to AC_USE_SYSTEM_EXTENSIONS. The former is obsolete and slated to be removed, the latter subsumes AC_GNU_SOURCE and other options.
I ran autoupdate and committed it, which fixed those things. I just wanted to test to make sure it didn't break the build on some older systems.
Also, I prefer $SHELL over sh because I have found Solaris's sh to be too broken to care about, and need to use /usr/xpg4/bin/sh instead. Hardcoding a path-less sh forfeits that.
configure is already hardcoded to use /bin/sh, so I don't think that is a problem. Does the configure script fail for you under Solaris?
