#3661: Version.sh might not run on platforms where /bin/sh is not bash
----------------------+----------------------
Reporter: marcusk | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Component: build | Version: 1.5.22
Resolution: | Keywords: patch
----------------------+----------------------
Comment (by dgc):
(Context: I wrote the version.sh in current use, perhaps modulo a few
patches since.) As a Solaris fan I'm generally very sensitive to shell
compliance. As Aaron said, I believe the version.sh currently in use is
fully compliant, but it's fair that $() is not serving any greater purpose
and can be replaced.
I purposely did not write it to use bash, since not all machines have a
bash installed. I'd prefer to identify specific problem points and fix
them than to make bash a build dependency.
Aaron's patch LGTM. Marcus, is there anything else that needs to be
addressed?
A patch to validate results would be good, but would require some
consideration (other than checking exit status).
--
Ticket URL: <http://dev.mutt.org/trac/ticket/3661#comment:3>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
