David Champion wrote: > * On 15 Mar 2013, Kevin J. McCarthy wrote: > > This patch set implements crypt_opportunistic_encrypt. This option > > allows mutt to automatically turn encryption on and off based on the > > message recipients. > > I've read over this roughly, and it looks good to me. I appreciate the > effort you put into compartmentalizing the separate patches.
Thank you for taking a look at the patch set (and for the other commits - hooray!). > My only question -- and I'm not a heavy crypto user, so this might be a > dumb question -- is whether this behavior should be a distinct option, > or whether it's really what we always want for automatic encryption. > That is: is it good as is or should it simply replace crypt_autoencrypt? I think it's a reasonable question. One reason I think it should remain separate is because this option can't always automatically determine a key for each recipient. The crypt_autoencrypt is still useful to force encryption on for certain recipients, even if you have to manually select their key when sending. Also, I imagine the "making a decision for you" aspect of this patch could be annoying. The patch series probably requires refreshing against current tip. I'm about to get on a plane back home (from overseas), but will be glad to refresh the series in a couple days. -Kevin
signature.asc
Description: Digital signature
