Ben Price wrote: > Patch below. This fixes the segfault, but I'm not sure the behaviour now > (list the public keyring) is what is wanted.
Tested and confirmed it fixes a segfault with <extract-keys> using gpgme. I think it would be even better to put a comment over gpgme_data_new_from_stream() to note that fin can not be closed while keydata is used. Although documented, this is surprising behavior. > The documentation seems to me to be contardictory, sometimes saying > "extract supported public keys", and sometimes "extracts PGP public > keys from the current or tagged message(s) and adds them to your PGP > public key ring". I don't know what the first means, and the behaviour > certianly isn't the second, but is what the actual code does (modulo > segfaulting!). The behavior is supposed to be extracting an attached key in the message (attached via the <attach-key> command) and importing it into your keyring. There is a TODO marked in the comment for pgp_gpgme_invoke_import() so perhaps the fact that extract keys didn't work was known but forgotten. Looking at the code, it looks like it IS attempting to extract a key and add it to the keyring. For some reason, it then ALSO lists all the keys in the keyring. > Unrelatedly: > 1) the manpage claims PGPPATH is honoured, but (using gnupg on > linux) this is not true - GNUPGHOME is honoured though. Looks like this is a remnant. I'll submit a patch for this shortly. > 2) the link to mailing list archives on the page > http://www.mutt.org/mail-lists.html seems to be broken Thanks for pointing those out. I think the mailing lists links were just discussed, but no one updated the page yet. Brendan, do you know who has access to this page? -Kevin
signature.asc
Description: PGP signature
