Oswald Buddenhagen wrote: > On Thu, Jan 15, 2015 at 02:44:14PM -0800, Kevin J. McCarthy wrote: > > Attached is a slightly revised version of this patch. The main > > difference with this version is a refactoring of the IMAP flag > > generation code. The previous patch added one flag too many to set > > using ternary operators. > > > this is certainly not very relevant in this specific case, but > strcat-like functions just aren't a terribly efficient way to join > strings, unless you use built-ins which the compiler understands to a > sufficient degree to replace them with something better.
Hi Oswald, Thank you for taking the time to look at the patch! I appreciate the feedback, and you're right, it's not a very efficient approach. I think for this case we're in agreement that it isn't too critical (since there will likely be just one or two flags), but again I appreciate it. -Kevin
signature.asc
Description: PGP signature
