#3743: Performance regression with 'color index' command in mutt 1.5.22
----------------------+----------------------
Reporter: sforshee | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Component: mutt | Version: 1.5.22
Keywords: |
----------------------+----------------------
I've noticed a substantial performance regression in the index whenever a
new page of messages is to be displayed, e.g. when opening a mailbox or
paging up/down in the index. This problem goes away if all 'color index
...' commands are removed from my .muttrc.
I bisected this and found that the problem was introduced in 1.5.22 by
this changeset b58cdfacfb89 "change semantics of mutt_is_autoview() to
return 1 if there is a matching mailcap entry and either
$implicit_autoview is set or the MIME type matches the user's auto_view
list."
This seems to be due to the addition of a call to rfc1524_mailcap_lookup()
in mutt_is_autoview(). Moving this call to only happen after determining
if the MIME type should be autoviewed according to the user's preferences
fixes the regression for me. I'm attaching a patch which does this.
--
Ticket URL: <http://dev.mutt.org/trac/ticket/3743>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
