Re: choices in crypt-gpgme.c

[Kevin J. McCarthy]

Derek Martin wrote:
> On Mon, May 11, 2015 at 09:48:05AM +0200, Moritz Barsnick wrote:
> > On Sun, May 10, 2015 at 21:47:07 -0500, Derek Martin wrote:
> > > There's a discussion about this in the archives... if anyone cares to
> > > dig it up.  Probably about 10 or 11 years ago I'm guessing, but I
> > > could be wrong.
> > 
> > Wow, that was (slightly) before I subscribed to the list. ;-)
> > 
> > It must be this thread (yes, between 10 and 11 years ago, bingo),
> > though I can't get gmane to show me the whole thread:
> > http://thread.gmane.org/gmane.mail.mutt.devel/6144
> 
> Yep that's the thread I meant.  I had actually brought this up
> first about a year earlier, and the original version of the patch I
> wrote (still up on pizzashack.org) is dated Sept. 10, 2003.  So yeah,
> long time ago. :-)

Thanks digging up the history behind the choice!

If this patch looks okay and is more helpful, I'll be glad to commit
it.

-Kevin

# HG changeset patch
# User Kevin McCarthy <ke...@8t8.us>
# Date 1431377258 25200
#      Mon May 11 13:47:38 2015 -0700
# Node ID 22e1293e62e251aa4db5f93a1fe9916a3d9c4b7f
# Parent  c46dfbdb5effa95846e69dceeab91a22c4ccad3a
Add comment about "(f)orget it" choice in send menus.

diff --git a/crypt-gpgme.c b/crypt-gpgme.c
--- a/crypt-gpgme.c
+++ b/crypt-gpgme.c
@@ -4742,17 +4742,18 @@
       else
       {
         msg->security &= ~APPLICATION_SMIME;
         msg->security |= APPLICATION_PGP;
       }
       crypt_opportunistic_encrypt (msg);
       break;
 
-    case 'f': /* (f)orget it */
+    case 'f': /* (f)orget it: kept for backward compatibility.
+               * See http://thread.gmane.org/gmane.mail.mutt.devel/6092/ */
     case 'c': /* (c)lear */
       msg->security &= ~(ENCRYPT | SIGN);
       break;
 
     case 'F': /* (f)orget it or (c)lear in oppenc mode */
     case 'C':
       msg->security &= ~SIGN;
       break;
diff --git a/pgp.c b/pgp.c
--- a/pgp.c
+++ b/pgp.c
@@ -1746,17 +1746,18 @@
       }
       *redraw = REDRAW_FULL;
       break;
 
     case 'b': /* (b)oth */
       msg->security |= (ENCRYPT | SIGN);
       break;
 
-    case 'f': /* (f)orget it */
+    case 'f': /* (f)orget it: kept for backward compatibility.
+               * See http://thread.gmane.org/gmane.mail.mutt.devel/6092/ */
     case 'c': /* (c)lear     */
       msg->security &= ~(ENCRYPT | SIGN);
       break;
 
     case 'F': /* (f)orget it or (c)lear in oppenc mode */
     case 'C':
       msg->security &= ~SIGN;
       break;
diff --git a/smime.c b/smime.c
--- a/smime.c
+++ b/smime.c
@@ -2055,17 +2055,18 @@
 
       *redraw = REDRAW_FULL;
       break;
 
     case 'b': /* (b)oth */
       msg->security |= (ENCRYPT | SIGN);
       break;
 
-    case 'f': /* (f)orget it */
+    case 'f': /* (f)orget it: kept for backward compatibility.
+               * See http://thread.gmane.org/gmane.mail.mutt.devel/6092/ */
     case 'c': /* (c)lear */
       msg->security &= ~(ENCRYPT | SIGN);
       break;
 
     case 'F': /* (f)orget it or (c)lear in oppenc mode */
     case 'C':
       msg->security &= ~SIGN;
       break;

signature.asc
Description: PGP signature