#3765: Warnings on OS X during make phase.
-------------------------+----------------------
Reporter: balderdash | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
Component: build | Version:
Resolution: fixed | Keywords:
-------------------------+----------------------
Changes (by Kevin McCarthy <kevin@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [8c16206f50a1d07b85873e3dfa1ac1027678f371]:
{{{
#!CommitTicketReference repository=""
revision="8c16206f50a1d07b85873e3dfa1ac1027678f371"
Fix compiler type warnings. (closes #3765)
The output of mutt_local_tz() was being passed to abs(). Technically
the return type is time_t, but it represents a small value: the timezone
offset in seconds. Add a safe explicit cast to int.
Change the txt parameter of mutt_make_help() to type const char *.
Typically all calls run the txt parameter through _(), which
accepts const char * and returns a char *. However, if NLS is not
enabled, _() is a noop, simply returning the parameter itself. In
mutt_compile_help(), items[i].name is const char *, so it will generate
a warning when passed as the txt parameter of mutt_make_help().
On some systems, e.g. OS X, snprintf is defined as a macro. One call
in hcache.c was embedding directives inside the snprintf call. This is
apparently undefined behavior, so duplicate the call instead.
}}}
--
Ticket URL: <http://dev.mutt.org/trac/ticket/3765#comment:3>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
