On Thu, Sep 03, 2015 at 01:07:48AM +0200, Hannes Wenzel wrote:
> >Just to check, you have confirmed the contents of "subkey->timestamp",
> >being passed to localtime() is 1402331216?
> Checked it.
> 
> There is a warning issued for that line:
> 
> passing argument 1 of 'localtime' from incompatible
> pointer type
> 
> Maybe the compiler has a wrong idea about the length of the timestamp?
> I added a line for clarification to the code (crypt-gpgme.c:2084 with
> the latest release 1.5.24):
> 
> time_t t = subkey->timestamp;
> strftime(date, sizeof(date), "%Y-%m-%d", localtime(&t));
> 
> The segfault is gone now.
> 
> gpgme.h states 'long int timestamp' and localtime expects (time_t *).
> I have not looked it up, but I think time_t is long long int at my
> platform. Guess, that's it.

Very nice investigation!  It's a bummer we just released 1.5.24
yesterday, but I'll get a patch into the stable branch for this.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA
http://www.8t8.us/configs/gpg-key-transition-statement.txt

Attachment: signature.asc
Description: PGP signature

Reply via email to