On 2016-03-29 13:42:32 -0700, Will Yardley wrote:
> On Tue, Mar 29, 2016 at 01:21:28PM -0700, Kevin J. McCarthy wrote:
> > On Tue, Mar 29, 2016 at 11:46:27AM -0700, Will Yardley wrote:
> > > Just wondering if folks think it would be desirable to make the date
> > > string in the build version configurable. I am not a big security
> > > through obscurity fan, but I just find it messy looking to have the date
> > > there.
> >
> > I don't feel strongly about the date being there. How do the other
> > developers feel about just removing the date?
Well, I like to have the date (it can provide useful information,
e.g. to make sure that one has an up-to-date version when one
uses several machines), but I won't complain if it were removed.
> It was put there for a reason, and I think for people running dev
> builds, maybe it's useful to have a date or Mercurial revision hash
> there.
I have my own patch (attached) to put the revision number and the date
for that. The date is redundant information, but more meaningful for a
human (though less accurate).
> I'm wondering if it's possible to have just a fixed version string when
> someone's building from a "release", though; at that point, the date
> becomes kind of pointless (that is, Mutt 1.5.24 release should always be
> from the same date anyway).
By default, the date comes from the changelog:
echo 'const char *ReleaseDate = "'`head -n 1 $(srcdir)/ChangeLog | LC_ALL=C
cut -d ' ' -f 1`'";' > reldate.h.tmp
So, why isn't it fixed for you?
--
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
diff -Naurd mutt-hg/Makefile.am mutt-vl/Makefile.am
--- mutt-hg/Makefile.am 2009-03-17 16:53:49.000000000 +0000
+++ mutt-vl/Makefile.am 2009-04-07 12:31:11.000000000 +0000
@@ -115,8 +115,10 @@
$(srcdir)/OPS.MIX $(srcdir)/OPS.CRYPT $(srcdir)/OPS.SMIME \
> keymap_alldefs.h
-reldate.h: $(srcdir)/ChangeLog
- echo 'const char *ReleaseDate = "'`head -n 1 $(srcdir)/ChangeLog |
LC_ALL=C cut -d ' ' -f 1`'";' > reldate.h.tmp; \
+reldate.h: reldate
+
+reldate:
+ rev=`hg identify -n | sed 's/\([0-9]\+\).*/\1/'`; echo 'const char
*ReleaseDate = "'`((cd $(srcdir) && hg log -r$$rev:$$((rev-20)) --template
'{date|shortdate}\n') || head -n 1 $(srcdir)/ChangeLog) 2> /dev/null | sort |
tail -n 1 | LC_ALL=C cut -d ' ' -f 1`'";' > reldate.h.tmp; \
cmp -s reldate.h.tmp reldate.h || cp reldate.h.tmp reldate.h; \
rm reldate.h.tmp
diff -Naurd mutt-hg/doc/Makefile.am mutt-vl/doc/Makefile.am
--- mutt-hg/doc/Makefile.am 2009-04-07 11:07:23.000000000 +0000
+++ mutt-vl/doc/Makefile.am 2009-04-07 12:31:11.000000000 +0000
@@ -168,8 +168,8 @@
stamp-doc-xml: makedoc$(EXEEXT) $(top_srcdir)/init.h \
manual.xml.head $(top_srcdir)/functions.h $(top_srcdir)/OPS*
manual.xml.tail \
- $(srcdir)/gen-map-doc $(top_srcdir)/VERSION
$(top_srcdir)/ChangeLog
- ( date=`head -n 1 $(top_srcdir)/ChangeLog | LC_ALL=C cut -d ' ' -f 1`
&& \
+ $(srcdir)/gen-map-doc $(top_srcdir)/VERSION ../reldate.h
+ ( date=`LC_ALL=C cut < ../reldate.h -d '"' -f 2` && \
sed -e "s/@VERSION\@/`cat $(top_srcdir)/VERSION` ($$date)/"
$(srcdir)/manual.xml.head && \
$(MAKEDOC_CPP) $(top_srcdir)/init.h | ./makedoc$(EXEEXT) -s && \
$(MAKEDOC_CPP) $(top_srcdir)/functions.h | \
