On Sat, May 07, 2016 at 04:14:36AM -0400, Damien Riegel wrote: > Because that means mx.c would have some kind of knowledge of all the > mailboxes it supports. It is yet another switch case or if statement > that would need to be modified when adding a new kind of mailbox. I > think multiple calls to stat have a very minimal perfomance impact, so > it doesn't really matter for now.
I didn't read all the patches, so I'm not really sure what the use case for the "multiple calls to stat" is, so take this comment if it's relevant and ignore it otherwise. :) Calling stat() multiple times is generally fine, when you know that the target is a local filesystem. It starts to get more "interesting" if your filesystem is networked (network latency vastly outweighs the actual stat time), and/or if your filesystem is simulated via FUSE or some other abstraction library, where the stat operation is expensive (like a database lookup). It may not be relevant to the average user, but it can matter. This is the world I live in. =8^) -- Derek D. Martin http://www.pizzashack.org/ GPG Key ID: 0xDFBEAD02 -=-=-=-=- This message is posted from an invalid address. Replying to it will result in undeliverable mail due to spam prevention. Sorry for the inconvenience.
signature.asc
Description: PGP signature
