Hi, On Wed, Aug 31, 2016 at 12:20:59AM -0700, David Champion wrote: > * On 30 Aug 2016, Oswald Buddenhagen wrote: > > > When $flag_safe is set, flagged messages cannot be deleted. > > > > > note that many of your patches have a "malformed" summary: you should > > use imperative (or simple past, but kevin appears to prefer the former). > > you're supposed to describe a transition, not a state. > > That's ideal for a bug fix. It works less for new capability, where > describing the transition from a code perspective doesn't really tell > you anything since the prior state didn't exist. > > Unless you're suggesting simply "Add $flag_safe." I'm OK with that, > but see below.
That's because you describe the diff here, and not the purpose of the patch. You could change the commit title to something like "Add a flag to prevent some messages from being deleted". Thanks, -- Damien
