On 31-08-2016 09:13:37 -0700, Kevin J. McCarthy wrote: > On Mon, Aug 29, 2016 at 11:24:13AM +0200, Fabian Groffen wrote: > > While trying to compile Mutt on Solaris, I found that since > > > > 6837:ce71d168c819 > > > > getaddrinfo is used for hostname resolution, which needs socket libs. > > Please find a patch for inspiration. As far as I can tell, we always > > need socket libs now, hence I removed the entire conditional. > > Thanks for the patch Fabian, I'll take a look at this soon.
Thanks. It seems that removing the entire need_socket wasn't a good idea, since it's used lateron for evaluating whether or not things like --with-sasl make sense, so just checking the libs unconditionally as in the revised patch attached is enough. Fabian -- Fabian Groffen Gentoo on a different level
# HG changeset patch # Parent fb897cf918f5a7496aa4aa79de010fccc6d6030f configure: drop conditional for socket library checks Since getaddrinfo is now used to determine the local hostname, we always need to check for socket support and necessary libs. I found this on Solaris as it needs -lsocket -lnsl for getaddrinfo. diff -r fb897cf918f5 configure.ac --- a/configure.ac Sun Sep 16 09:31:54 2012 +0200 +++ b/configure.ac Sun Sep 04 13:40:09 2016 +0200 @@ -624,21 +624,18 @@ fi dnl -- end socket dependencies -- -if test "$need_socket" = "yes" -then - AC_CHECK_HEADERS([sys/select.h]) - AC_MSG_CHECKING([for socklen_t]) - AC_EGREP_HEADER(socklen_t, sys/socket.h, AC_MSG_RESULT([yes]), - AC_MSG_RESULT([no]) - AC_DEFINE(socklen_t,int, - [ Define to 'int' if <sys/socket.h> doesn't have it. ])) - AC_CHECK_FUNC(gethostent, , AC_CHECK_LIB(nsl, gethostent)) - AC_CHECK_FUNC(setsockopt, , AC_CHECK_LIB(socket, setsockopt)) - AC_CHECK_FUNCS(getaddrinfo) - AC_DEFINE(USE_SOCKET,1, - [ Include code for socket support. Set automatically if you enable POP3 or IMAP ]) - MUTT_LIB_OBJECTS="$MUTT_LIB_OBJECTS account.o mutt_socket.o mutt_tunnel.o" -fi +AC_CHECK_HEADERS([sys/select.h]) +AC_MSG_CHECKING([for socklen_t]) +AC_EGREP_HEADER(socklen_t, sys/socket.h, AC_MSG_RESULT([yes]), + AC_MSG_RESULT([no]) + AC_DEFINE(socklen_t,int, + [ Define to 'int' if <sys/socket.h> doesn't have it. ])) +AC_CHECK_FUNC(gethostent, , AC_CHECK_LIB(nsl, gethostent)) +AC_CHECK_FUNC(setsockopt, , AC_CHECK_LIB(socket, setsockopt)) +AC_CHECK_FUNCS(getaddrinfo) +AC_DEFINE(USE_SOCKET,1, + [ Include code for socket support. Set automatically if you enable POP3 or IMAP ]) +MUTT_LIB_OBJECTS="$MUTT_LIB_OBJECTS account.o mutt_socket.o mutt_tunnel.o" dnl -- imap dependencies --
signature.asc
Description: Digital signature
