On Tue, Aug 30, 2016 at 06:03:37PM -0700, [email protected] wrote: > Adds label completion. > > A global label hash is added, to which labels are added as they're parsed > from a mailbox file or edited manually by the user. Reference counts are > kept in the hash table so that unused labels are removed from available > completions. Completion is available in the label editor only, but it > may be feasible to add for search expressions if the preceding text ends > with '~y'.
Hi David, I two questions/comments. The first is regarding uintptr_t: do you need to include <stdint.h> to use this now-a-days? If so, then I think there is a HAVE_STDINT_H set in config.h that may need to be consulted too. The second is about the Labels creation/updating locations, currently in curs_main.c and main.c, and declared in globals.h. I think since the labels are tied to the context, they should be stored in the context and updated in the same places as subj_hash and id_hash. Currently, it doesn't look like you are hooked into mailbox reopens, messages being deleted, etc, so it would be an improvement that way, and would also look a bit cleaner: it's a bit odd having those hash tables exposed and maintained where they are. That's just my opinion though! :-) -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
