#3880: integer overflow in date.c (mutt_mktime)
-----------------------+----------------------
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: new
Priority: critical | Milestone:
Component: mutt | Version: 1.7.0
Resolution: | Keywords:
-----------------------+----------------------
Comment (by kevin8t8):
The comments for mutt_mktime() indicate it doesn't take the local timezone
into account (unless local is true). The system mktime() says it takes
the struct tm to be in the local timezime. So, I'm surprised if it can
really be just swapped out like this.
That said, I agree with Derek that it would be much better to use the
system mktime() if at all possible. Perhaps by reversing the adjustment
from compute_tz() if (!local)?
Timezone and date issues easily confuse me, so I'll need to take a closer
look before committing anything too radical.
Derek, I will email you information about your trac accounts. Password
resets were hosed for a while, but Brendan fixed that earlier this year.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3880#comment:19>
Mutt <http://www.mutt.org/>
The Mutt mail user agent