On Sat, Nov 05, 2016 at 02:12:09PM -0700, Kevin J. McCarthy wrote: > On Fri, Nov 04, 2016 at 06:04:01PM -0400, Damien Riegel wrote: > > This new placeholder allows to print the attachment name as it will be > > seen on the recipient side. > > Hi Damien, > > I'm just curious if you tried putting the new "%F" option case statement > above the "%f", and having it fall through if d_filename is NULL? > > This way, by default (with %d), the user sees content->description if > there is one, then content->d_filename if there is one, and falling back > to content->filename. > > This also keeps the mutt_pretty_mailbox() call in %f. > > I'm attaching a (very lightly tested) patch based on top of yours. > What do you think?
I think it's good enough for now. I don't like the fact that the patch has to change something in the 'd' case to add a new format character, but it's the least intrusive way to do this change, so let's do this. I gave it a few tries in receive and compose mode and could not spot any bugs. Feel free to discard my patch to use yours directly instead. Thank you for the review, -- Damien
