On Mon, Dec 11, 2017 at 09:46:30PM -0500, Aaron Schrab wrote: > At 19:37 -0800 10 Dec 2017, "Kevin J. McCarthy" <[email protected]> wrote: > > Sorry things have been so quiet. I've been pretty busy on other stuff, > > but what time I have had available has been working on migrating Mutt to > > git. > > Nice. As someone who's been building mutt from a git clone for years, this > is definitely welcome news to me. > > Based on my experience in that time, I'd recommend not relying on `git > describe` to generate the version string. As shown in the link below, it can > sometimes give very strange results. The patch here modifies version.sh to > avoid this use, I have been using this method for about a year now (since > shortly after I sent the message at that URL).
Thanks Aaron. I'll take a look at this later on today. Based on the thread you linked to, it looks like the `describe` sometimes works and sometimes not. That's too bad, but your patch looks fine. To keep consistent with current behavior, I'll probably remove the 'g' and dirty flags though. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
