On Wed, Jun 03, 2020 at 11:15:46AM +0100, isdtor wrote:
I wasn't happy with the way autocrypt was added to configure but then realized that there is only one real problem with it. The code makes assumptions that aren't backed by configure tests.The autocrypt code uses sqlite3_prepare_v3(), added in version 3.20, and without a version check, building will fail at the linker stage.
Thanks for the patch. Not checking sqlite_prepare_v3() was an oversight; I didn't realize it was such a recent addition.
However, this is a simple fix, and doesn't require replacing the whole thing. In general, I'd prefer to not add more "stuff" to the m4 directory unless it really is necessary.
For now I'll add a check:
AC_CHECK_FUNC(sqlite3_prepare_v3, [],
AC_MSG_ERROR([sqlite3 version 3.20 or greater is required]))
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
