On Sat, Jun 27, 2020 at 06:22:52PM -0700, Kevin J. McCarthy wrote:
Well, that's my theory anyway. Perhaps the escaping was a mistake, only intended to be done with "set ?var" output. I'm not sure how much the behavior is relied on (or even how helpful the escaping is...), but again I'm afraid of breaking configs after 20 years of established behavior.
I've been thinking about this a *lot* more, and digging into past commits. It looks like the escaping has pretty consistently been intended for value completion and queries. See commits 3c00eb7a and 032dcbeb.
I don't believe the escaping is useful for variable expansion as part of mutt_extract_token() - even for the hook "command" argument case. The escaping is targeted only for an expression surrounded by double quotes (as is generated by completion and queries). It doesn't escape single quotes or spaces, for instance.
So I'm going to go all the way and pull it out for variable expansion in all cases. I'll document it, and am even considering bumping the next release to 2.0 to denote possible incompatible changes. (see also ticket 253 where I'm planning on changing reply_to to override $reply_self).
If any of the older developers would care to contradict me on my conclusion, now would be the time.
Thanks again, everyone. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
