On Wed, Jul 22, 2020 at 01:39:41PM -0700, Kevin J. McCarthy wrote:
On Wed, Jul 22, 2020 at 09:15:39AM -0700, Kevin J. McCarthy wrote:It looks like this version is now changing behavior with $cursor_overlay unset. The tree colors should not be drawn (with $arrow_cursor unset)in that case. Would you confirm that is still the case.Sorry, my mistake. I looked too quickly and didn't see the tree was being reset to the indicator color when use_indicator is set and $cursor_overlay is unset.Let me take another look and test it a bit more. I think this might be fine as-is.
One suggestion might be to remove the mutt_attrset_cursor() calls before print_enriched_string(,,1). And inside print_enriched_string() instead:
int tree_color = mutt_merge_colors (base_color, ColorDefs[MT_COLOR_TREE]);
if (use_indicator)
{
tree_color = mutt_merge_colors (tree_color, ColorDefs[MT_COLOR_INDICATOR]);
base_color = mutt_merge_colors (base_color, ColorDefs[MT_COLOR_INDICATOR]);
ATTRSET (base_color)
}
Otherwise we're doing necessary work to calculate the base_color twice.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
