On Sat, Aug 21, 2021 at 07:15:12AM -0700, Kevin J. McCarthy wrote: > On Sat, Aug 21, 2021 at 11:35:19AM +0200, Pieter-Tjerk de Boer via Mutt-dev wr
> > This bug isn't just cosmetic; it can lead to unintended deletion of > > large amounts of mails. > > I'm very sorry to hear about the loss of email. That's the most terrible > bug there can be. :-( Thanks; indeed, I was not amused, and that's an understatement... :-( > > Fortunately, fixing this is trivial; at two places in imap/message.c, > > replace > > ctx->hdrs[idx]->index = idx; > > by > > ctx->hdrs[idx]->index = h.data->msn-1; > > Unfortunately I don't think this is the correct fix. There can in fact be > holes in the MSN sequence. I'm by no means an IMAP or mutt code expert (never touch mutt code, nor studied the IMAP RFCs, until trying to fix this bug), but in RFC3501, section 2.3.1.2, the MSN is described as "A relative position from 1 to the number of messages in the mailbox". This implies there can be no holes, or am I overlooking something? > I think a better fix would be changing the sort order to use UID instead > when creating the msgset, Indeed, that would be a more robust solution to the message delete problem, as it then no longer relies on MSN and UID being monotonically related. But I think it wouldn't solve the problem that the unsuccesfully-deleted message jumps to a different position in the unsorted mailbox view. Regards, Pieter-Tjerk
