On Tue, May 24, 2022 at 11:19:43AM -0700, "Kevin J. McCarthy" <[email protected]>
wrote:
> On Tue, May 24, 2022 at 09:58:08AM -0700, Kevin J. McCarthy wrote:
> > On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote:
> > > +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]{}$`'~\"\\*?"
> > > + if (Sendmail[strcspn(Sendmail, SHELL_NON_SPACE_META_CHARACTERS)] !=
> > > '\0')
> > > + {
> > > + mutt_error(_("$sendmail cannot contain shell meta-characters."));
> > > + return -1;
> > > + }
> >
> > Also, taking a closer look at the patch.
> >
> > * strcspn() matches an initial prefix. You might want to use strpbrk()
> > instead.
>
> Err... sorry my mistake! The strcspn() usage in your patch is correct - my
> brain was confused. :-/
That happens to me too! :-)
> --
> Kevin J. McCarthy
> GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
cheers,
raf
