Hi David, Thanks for the patch.
On Wed, Oct 19, 2022 at 12:01:36PM -0500, David Vernet wrote:
In imap_check_mailbox(), there is an if clause where we potentially poll IMAP with a NOOP command. This can be invoked on many ops, including if we e.g. move to the next message on the index. According to http://www.mutt.org/doc/manual/#timeout, the expected behavior of Timeout is that a timeout value of <= 0 will cause Mutt to never time out.
It looks like "never timing out" used to be the case, but was slowly changed (e.g. commit 2fee61e1).
Now, km_dokey() will change <=0 to 60, to make sure IMAP keepalive's run.
The documentation should be fixed for that.I agree imap_check_mailbox() should be fixed so it isn't blasting NOOPs all the time too. But the side effect of your patch would be to almost never send NOOPs, which would make Mutt very slow to notice new mail (unless $imap_idle is in use).
What if it did the same thing as km_dokey(), changing <=0 to 60? -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
