On Wed, Feb 25, 2026 at 11:53:25AM +0100, Rene Kita wrote:
+test -d "$LIBICONV"/libcharset/tools || {

imo, these constructs look really unnatural and noisy. why not just quote the entire string ("word" in shell terms)?

+for f in "$LIBICONV"/libcharset/tools/* ; do

here it gets a bit fuzzy. i'd probably quote right up to the asterisk, but i have no strong preference.

Reply via email to