On Sun, Jun 21, 2026 at 06:02:06PM +0200, Alejandro Colomar via Mutt-dev wrote:
On 2026-06-21T17:31:38+0200, Vincent Lefevre wrote:On 2026-06-20 22:48:38 +0200, Alejandro Colomar via Mutt-dev wrote: > Comparison with a literal should not use casts.OK here, but why is there a cast for the assignment, then? If the cast is useless for the comparison, then it should also be useless for the assignment.Agree. I'd remove it. I'd remove most casts in any program, FWIW, and wrap all the few remaining necessary ones in macros that make them easy to grep and verify. In this case, I'd remove the cast in the assignment.
I pushed this commit up over the weekend. However, if someone wants to clean up the unneeded casts in the function, I'll commit it too.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
