On Thursday 31 January 2008 04:00:58 Simon Hyde wrote: > On Mon, 28 Jan 2008, Darren Hart wrote: > > It was suggested I post a link to the compiled dongle with my recent > > patches. Thare are three UI Viewport patches and one new date and > > duration formatting patch. > > I finally got around to trying to review/apply and test this patch. There > are a few issues I can see on a standard layout without the viewport > adjusted: > > 1. The description below the main list menu in the mythtv interface has > been shifted to the right, previously it sat below the logo off to > the left. This leaves a lot less space for program information before you > get to the postage stamped video are.
True. This was a tradeoff to be able to use a much shorter screen area. An alternative might be to reduce the size of the mythTV logo (boy... wouldn't SVG be awesome! :-). I'm not experiencing any trouble myself, but I know there are a lot of settings that can affect this - font size being one that comes to mind... > > 2. The description now crashes over the top of the video thumbnail in the > mvpmc menus. The description (and the menu above, i suspect) need to be > dynamically sized to cope with moving themselves around a statically sized > video thumbnail> . Hrm, yes it does. I'll take a look and update the patchset. > > 3. The video thumbnail isn't moved around with the viewport, this can be > achieved by working with video_thumbnail in video.c Thanks, I missed that, I'll look into it for the next rev. > > 4. I think the default viewport is a little too small, I'd need to look at > this with a waveform monitor to see where things are falling > > Other than that the patches look quite good. It'd be easier to apply them > if they were generated using a command along the lines of: > > mkdir ~/mvpmc_patches > cg-mkpatch -r origin.. -d ~/mvpmc_patches Thanks, that is what I needed - descriptions in high level languages (English) were leaving me a bit confused on how exactly I should be creating the "git commits" that were asked for. I'll submit the next version this way. Thanks for the feedback, I certainly have a good todo list. I'll get to work and post the next rev as soon as I can. Regards, Darren Hart > > That should give you a set of patches to be emailed in ~/mvpmc_patches, > which can be easily merged by any mvpmc developer using cg-patch. > > Cheers, > > Simon -- Darren Hart IBM Linux Technology Center Real-Time Linux Team ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Mvpmc-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mvpmc-users mvpmc wiki: http://mvpmc.wikispaces.com/
