Update of bug #17907 (project mypaint):
Status: In Progress => Fixed
Summary: A new Brush Editor pannel redesigned by Shock =>
Group settings in Brush Editor
_______________________________________________________
Follow-up Comment #7:
The patch introduced a style change (adding a border). Please don't do such
as a sideeffect of another commit, at least not without noting it in the
commit message. We don't use borders in other very similar cases
(brushselectionwindow, functionwindow for instance). If you think we should,
provide another patch that covers all cases (so that we are consistent) and
explain the rationale in the commit message.
The resizing behavior was not as expected. Expanding widgets typically do not
make sense in scrollable areas.
So I committed it with the following two fixups:
- vbox.set_border_width(5)
- brushsetting_vbox.pack_start(group_expander)
+ brushsetting_vbox.pack_start(group_expander, expand=False)
http://gitorious.org/mypaint/mypaint/commit/da7224480c5484b8d5091ce669d6ec649ce79cdd
Thanks!
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?17907>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Mypaint-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-bugs
