Follow-up Comment #5, bug #18765 (project mypaint):
I've managed to integrate all your experiment into the latest git version
with one exception: "get_color_rgb" call in OnCanvasCursor in cursor.py
doesn't seem to work and throws an error, although I have set it before on
color picking. Anyway, I used gray color, I don't think that changes the
experiment too much, as it is all about brush size, but I would really want to
know how I should fix this.
First of all, the get_actual_radius function implemented in brush.hpp doesn't
seem to approximate correctly the size of the brush at various zoom levels.
Maybe the math behind brush scaling has changed, I will need a confirmation on
that.
Second, I don't think this is a big performance hit. It is true I run a quite
powerful machine (i7 based desktop), but I didn't notice slowdowns because of
our drawn cursor particularly. While it is true that if I zoom out and draw
things around with a big brush, it will work very slow, but it does so even
without drawing any cursor at all.
So my conclusions are:
1. This should definitely be in the git version as there are people using
fast computers nowadays, with a switch in options menu to turn it off. If you
could provide me with a fix for the "get_color_rgb" and a hint about how
"get_actual_radius" should work to return the proper radius, I think I can
submit a patch with everything, including the options switch, without you
having to bother with all the details.
2. The code for drawing is definitely slow for bigger images and should be
improved. I heard about new photoshop versions using the power of multi-core
machines and hardware acceleration to do this. I think i could also look into
this once the original problem is solved.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?18765>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Mypaint-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-bugs
