On Sun, Jul 12, 2009 at 02:23:09PM -0300, Álinson Santos wrote:
> 2009/7/10 Martin Renold <[email protected]>:
> > When this is fixed it can go into main repository. I did not give it much
> > thought yet, but I'm sure there is a practical solution for this.
> 
> Done. The patch follows.
> It contains a couple of other minor changes too.

Nice, another 20% speedup.  I have pushed it now.  I took the liberty to add
your test results into the commit message.

I also noticed (kind of last-minute) that it breaks saving of PNG and
merging layers, both through the same codepath.  Fixed in commit 91bed47.

I have some small questions left:
- Why initialize mipmap_dirty with False and not True?
- "if mipmap_level < MAX_MIPMAP_LEVEL:" wouldn't the logical thing be <= ?

And thanks a lot for this patch!

bye,
Martin

_______________________________________________
Mypaint-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-discuss

Reply via email to