hi Olivier,
On Wed, Feb 10, 2010 at 12:25:47AM +0100, Popolon wrote:
> This is a git format patch
Actually, it isn't. A git format patch would be something generated with the
command "git format-patch". You should find tutorials if you google this.
> for adding toogle in menues, for :
> * Layer solo
> * Hide layer above
> * Eraser (sometimes (I sometime don't know in which mode I'm)
> * Toggle subwindows
Might be a good idea.
> Could be added on some subwindows, but I'm not sure this is really usefull
Maybe that would be a little bit too much, especially because it is not
trivial to implement.
> [...]
> + ('ToggleSubwindows', None, _('Toggle Subwindows'), 'Tab',
> None, self.toggle_subwindows_cb),
> + ('SoloLayer', None, _('Layer Solo'), 'Home', None,
> self.solo_layer_cb),
> + ('ToggleAbove', None, _('Hide Layers Above Current'), 'End',
> None, self.toggle_layers_above_cb),
> + ('Eraser', None, _('Toggle Eraser Mode'), 'e', None,
> self.eraser_cb),
Just turning those menu entries into checkboxes will not make them work
reliably. The checkboxes also need to be updated when something other than
the menu action toggles the feature.
There are many ways to enter and leave eraser mode without using the menu,
eg. by selecting a different color. Even with "Layer Solo" it is not hard
to get the checkbox the wrong way around after your patch. See
drawwindow.py line 672 for an example what has to be done in the case of
"Mirror Image".
And the menu entry should not say "Toggle <something>" any more; when it has
a checkbox its label should say what it enables when checked, otherwise the
checkbox is useless information.
--
Martin Renold
_______________________________________________
Mypaint-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-discuss
