On Sun, May 16, 2010 at 1:05 AM, Andrzej Giniewicz <[email protected]> wrote: > Hi once more time, 2 patches again - this time I will take a break > from making them as other tasks will absorb me for a while, unless > they need some work. Hi, and thank you for the continued contributions!
> Second changes way settings.conf is loaded and saved - > detailed description in patch. I ended up doing this, because I wanted > to add other simple thing I thought might be useful (checkbox for > "start fullscreen") - at least for me - so I needed to add entry to > settings.conf with it. When I added it, I noticed, that adding new > entry made it fail when I used dummyobj[name], because file > settings.conf was present but without field with name I needed, so I > either had to remove settings.conf, or change dummyobj[name] into > dummyobj.get(name, default). Second solution sounded better - but it > would work in different way (default values) than 3 already present > options, so I though - why not use get(name, default) for all options? > I also moved all settings into global list - and made load/save > iterate over it, it makes whole thing shorter and I think cleaner - > that way, adding new option can be done in single place with single > line - and no special changes to user-side .conf file should be > needed. This area is actually very work-in-progress. I want to get rid of the whole "interpret the settings file as python code", and move to a "real" settings file format. I have patches for this in my json_prefs branch: http://gitorious.org/~jonnor/mypaint/jonnors-clone/commits/json_prefs So unless there is an issue with those, I suggest that we just do that instead. The major potential issue is of course that it requires json support. Which means either Python 2.6 or one of the libraries listed in the first patch. Anyone think this is too problematic? > Other change I added there, is saving only what isn't default > - but this might as well be not so good :) Do we want this or not? I'm in favor of not, since it means settings can change for the user when we change the defaults. The only current setting we would to that with would be scrap prefix, but that would be very surprising behavior. > Oh, btw - It's late already here and I don't have time to open bug > report or look/ask if it is or isn't a bug - so I'll ask here to raise > it and not forget about it - if I'm in fullscreen mode and menubar is > hidden, when I access menubar using menu key (and it shows), Quit > works only when accessed using keyboard (arrows+enter, > highlight+enter, shortcur), but if I click on it (using any pointing > device), nothing happens (well, menubar disappears again) - I haven't > checked other menu commands, but is it intended or known behaviour? > It's like that in current git and also in released 0.8.x, don't know > about others. I can reproduce in 0.8.2 (didnt test git master). I'd say that this is a bug. -- Regards Jon Nordby - www.jonnor.com _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
