On Sat, May 15, 2010 at 04:31:13PM +0200, Andrzej Giniewicz wrote: > > About behaviour - it is quite obvious, dragging brush to group label > that do not have given brush adds it at end of list - in case brush is > there already it's removed from source group (to make it similar to > behaviour when dragging between groups list).
Yes, behaviour seems okay. I found only a small glitch: the cursor shows a copy action when there is in fact a move happening. (I am not so convinced any more that it is a good idea to remove brushes from a group that way, but it is good to be consistent. I think there are some alternative ideas in the wiki GUI brainstorm.) > I wasn't sure about checking if drop event comes from BrushList the way I > did this in this patch (isinstance), but it might get messy if someone > would drag something from something else that uses PixbufList (if there is > or is planned anything that do) - this check there might require some > tweaks so I'm open for hints how you solve such situation so I can move > along same style Yes maybe this is a bit ugly conceptually; I think it is not a problem right now (we don't have any other brush drag sources), and can be fixed easily later if required. At the moment PixbufList is also used by the background pattern selector, but this is not a drag source. I pushed your patch, thanks! -- Martin Renold _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
