On Sun, Jun 13, 2010 at 12:17:21PM +0200, Till Hartmann wrote: > On 12.06.2010 23:02, Martin Renold wrote: > > But... we are saving our own file here. We should really /know/ its mime > > type. Maybe just use a hardcoded dictionary mapping our well-known > > extensions to their mime type (or can they change depending on the system?). > I am not sure about this, I mean, there's a python API for mimetypes > with predefined entries, but I think you can also either add to that map > or provide your own. However, before I changed this the mimetype was > *always* application/octet-stream.
My impression was that the mimetypes module is meant mainly for guessing the mimetype of a file with unknown origin. I agree of course that your change is an improvement, maybe I just got a bit carried away commenting everything while I was at it. > >> +++ b/gui/layerswindow.py > >> @@ -361,17 +361,20 @@ class Window(windowing.SubWindow): > >> add_button = stock_button(gtk.STOCK_ADD) > >> move_up_button = stock_button(gtk.STOCK_GO_UP) > >> move_down_button = stock_button(gtk.STOCK_GO_DOWN) > >> + merge_down_button = stock_button(gtk.STOCK_DND_MULTIPLE) > > > > Hm, that stock icon may change appearance to something else. But never mind, > > should be good enough for now and can be fixed when it screws up. > > > I actually wrote a mail to this list with another email-account (but > since that account isn't subscribed to the mailing list, the mail did > not arrive) about this issue; I only used that stock icon because it is > theme independent - if you provide a custom icon (see attachment ;)) it > will break theme consistency, if someone uses another theme than for > example tango or humanity. Okay, I might have forgotten. I'm no expert in GTK theming and don't know what the proposed solution would be for that; we sure want other custom icons also to fit into the theme (maybe steal a bit from inkscape/gimp). But as I said, your change is fine with me. > I also wasn't sure how to add the icon (or, to be more precise: if there's > already some mechanism included in mypaint). There is the app.pixmaps instance of the PixbufDirectory class which is probably suitable for that. -- Martin Renold _______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
