@ David Gowers Please make any new patch against the new branch. rj/linemode
@ Martin I will change the commit message to reflect the contributions of the David Gowers, David Revoy, and Martin Renold. Regarding the curve and slider widget problems. Is there a way of using connect() with a button release event, somehow? I can confirm that this problem occurs for the sliders in the BrushMode panel as well as in my implementation of LineMode. Richard On Sun, Feb 19, 2012 at 5:54 AM, David Gowers (kampu) <[email protected]>wrote: > On Sun, Feb 19, 2012 at 7:47 PM, Martin Renold <[email protected]> wrote: > > Thanks for the update. > > > > If you squash commits, please do attribution for work done by someone > else > > in the commit message. The copyright note at the top of every file would > > get quite a burden if it was updated with every contributor's name. > > > > I did some 'git rebase -i' and 'git cherry-pick' to show what I mean, but > > I'm also happy if you just state it in the commit message: > > https://gitorious.org/~maxy/mypaint/maxy-experimental/commits/linemode > > > > Your updated branch contains new code (I think it's only the "curve > widget" > > patch from David Gowers). I like the idea of manipulating the shape that > > way, but I'm not convinced about the implementation yet. I was just > trying > > it quickly, and it has some obvious glitches: > > > > 1. When you drag a point over the border of the line of the widget > (which is > > easy to do accidentally), the widget disappears before you release the > > click. And when you open it the next time, you are still dragging the > point > > around. > To be clear, this problem also occurred with the sliders. > We need to pretend the button was released when the widget loses focus. > Well, not exactly -- I just tried that, and it's annoying. Rather, we > need to stop the window from being unfocused until we receive the > button release event. Unfortunately I don't know how to do this. > > > > > 2. The tooltip is too big and tends to get into the way, at least when > using > > the mouse. I would be very surprised if users did actually bother read > it > > unless they get really desperate. If the curve was labeled "Line > Pressure" > > instead of "Line Shape", the tooltip would be almost unnecessary - it's > > quite inuitive IMO. If there is a tooltip, I suggest to make it only > over > > the label, not the whole widget. > > Will do. > > > > I'm also sceptical about subclassing CurveWidget. By subclassing it, you > > have to duplicate the code in motion_notify_cb(). This is almost > guaranteed > > to get out of sync if anyone ever makes a change. > > > > I think the better approach, from a maintainer's point of view, would be > to > > add the new functionality to the original CurveWidget. It was already > done > > like that when re-using the widget for the global pressure preferences > > (self.magnetic), and it could be done like that again (just make the > ylock > > part of the normal widget, and add self.fixed_number_of_points or > similar). > I'm happy to do this work. Are you aware,though, that I altered the > snapping behaviour? In the subclass, self.magnetic has a greater > effect -- rather than snapping only to the midpoint (0.50,0.50), it > snaps to all internal grid points. Is it okay for the master pressure > curve in preferences to get that behaviour? >
_______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
