Hi. Long time MyPaint user, just compiled the git master (love the new
features!) and came up against the color history bug (
http://gna.org/bugs/?20129).

Here's a patch that reverts the color history picker to the 1.0.0 behavior:

>From 694d25ab9de7f5e9d82f6f06868b46022db4c208 Mon Sep 17 00:00:00 2001
From: John Watson <[email protected]>
Date: Thu, 4 Oct 2012 17:56:09 -0700
Subject: [PATCH] Fix color history regression bug 20129

---
 gui/colors/adjbases.py |    4 ++--
 gui/historypopup.py    |    6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gui/colors/adjbases.py b/gui/colors/adjbases.py
index 7586b0e..664b07b 100644
--- a/gui/colors/adjbases.py
+++ b/gui/colors/adjbases.py
@@ -141,8 +141,8 @@ class ColorManager (gobject.GObject):
         """
         while color in self.__hist:
             self.__hist.remove(color)
-        self.__hist.insert(0, color)
-        self.__hist = self.__hist[:self.__HIST_LEN]
+        self.__hist.append(color)
+        self.__hist = self.__hist[-self.__HIST_LEN:]
         key = PREFS_KEY_COLOR_HISTORY
         val = []
         for c in self.__hist:
diff --git a/gui/historypopup.py b/gui/historypopup.py
index 2ea9bd5..cef0a5e 100644
--- a/gui/historypopup.py
+++ b/gui/historypopup.py
@@ -69,6 +69,9 @@ class HistoryPopup(windowing.PopupWindow):
         self.doc = doc
         self.is_shown = False

+        guidoc = app.doc
+
 guidoc.input_stroke_ended_observers.append(self.input_stroke_ended_cb)
+
     def enter(self):
         # finish pending stroke, if any (causes stroke_finished_cb to get
called)
         self.doc.split_stroke()
@@ -103,6 +106,9 @@ class HistoryPopup(windowing.PopupWindow):
     def button_release_cb(self, widget, event):
         pass

+    def input_stroke_ended_cb(self, event):
+        self.selection = None
+
     def expose_cb(self, widget, event):
         cr = self.get_window().cairo_create()
         return self.draw_cb(widget, cr)
-- 
1.7.9.5
_______________________________________________
Mypaint-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-discuss

Reply via email to