Hi there - thanks for getting involved. There were a few problems with your patch that I'd like to iron out before accepting it, so I've attached an updated version of it which applies to the current master's HEAD:
* I've added the bits of Builder XML needed to make it work, and corrected a few spelling and whitespace mistakes. Hope it's still recognisable! * I notice that when both the size overlay and the rotation one are visible at the same time, they overlap. This might be due to me using a fairly large system font. Can this be fixed? * Is there any way of combining both size and rotation into the same text box, to avoid having to draw too many distracting/fairly arbitrarily sized blocks to the screen? * This sort of information would be great to have in the statusbar. I've been thinking about hiding the scale overlay when not in fullscreen mode, and using the bottom right of the statusbar to show it, like Inkscape. Any thoughts? A few stylistic suggestions: * Indents in Python code are four spaces, and should consist of only spaces (I got loads of whitespace errors here). Please be sure to do whatever's necessary in your editor to make it PEP8-compliant. Things are way more fluid for our C/C++/XML stuff. * No new GTK2 code please. MyPaint is an entirely GTK3 project, so feel free to drop GTK2-specific blocks. * In general, we prefer fairly clean patches with as few extra whitespace-only lines as possible (comments are fine :)). That said, I'm terrible at sticking to this "rule" myself. On 6 October 2013 18:32, Ariful Bhuiyan <[email protected]> wrote: > Hey guys, I want make use of the overlays feature that was implemented a > while ago in MyPaint, to show some key information. I am thinking of trying > to implement overlays for brush radius, opacity, hardness/pressure gain, and > maybe even tilt. > > So far, I have implemented an overlay to show the current rotation of the > canvas, and it seems to work fine, take a look at the patch below: > > -home > > _______________________________________________ > Mypaint-discuss mailing list > [email protected] > https://mail.gna.org/listinfo/mypaint-discuss > -- Andrew Chadwick
0001-overlays-show-the-current-rotation.patch
Description: Binary data
_______________________________________________ Mypaint-discuss mailing list [email protected] https://mail.gna.org/listinfo/mypaint-discuss
