I've had a little time to review this. Sorry for the delay:
It works nicely against git master, at least the original one does.
With some minor adjustments, I've been able to get scroll=pan working
on Xfce4 after a visit to the Settings Manager to turn on horizontal
scrolling for my tablet and my touchpad. People have asked for this
before, so it's worth having I think. The feel for smooth scrolling is
nice too. However:
0. Seems it cannot be turned off for touchpads and tablets, which is a
showstopper. These devices evidently only send GDK_SCROLL_SMOOTH
events when the event mask contains GDK_SMOOTH_SCROLL_MASK! I think
the handling of smooth scrolling events needs some work; perhaps it
could be made to work like old-style scroll "button" events by
considering and comparing the sign and magnitude of delta_x and
delta_y?
1. The second patch fails to apply to MyPaint master due to a
malformed line ending (rest of the patch is CRLF, but applying the
patch gives:
patch: **** malformed patch at line 102: diff --git
a/gui/preferenceswindow.glade b/gui/preferenceswindow.glade
which seems to pertain to that line's ending being just LF.
2. MyPaint crashes when launched with a fresh config and scroll is used.
File "/home/andrewc/Development/MyPaint/gui/document.py", line 1421, in pan
alt_scroll = self.app.preferences['ui.alt_scroll']
KeyError: 'ui.alt_scroll'
This is due to the lack of a default in gui.application.Application.
3. The wording of the prefs dialog is a bit vague. I think I'd prefer
a checkbox: """
Scrolling behaviour:
(x) Zoom and Rotate
( ) Panning
"""
4. Arguably it should go on the "devices" tab, since that controls
what devices can be used for :)
5. Please could you rebase against master (i.e. re-apply the committed
changes on your branch against the development head, e.g. "git pull;
git rebase master") and resubmit the patch using "git format-patch"?
It's moderately complex, and I'd like to see you have credit in the
changelog.
If you like I could rework these for you and see what I can do about
the smooth scrolling thing.
--
Andrew Chadwick
_______________________________________________
Mypaint-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-discuss
