The attached patch fixes a longstanding difficulty in setting up an HDTV Myth box, namely that you needed to go in and manually set the freqid field in your database as appropriate for each of your stations.
Look back in this thread for the rest of the details.
This version is the same as the old one, with the exception that for new HDTV stations using DataDirect, their channel number is set to <major>_<minor>, complete with underscore; the channel-changing code now accepts underscore as a valid channel character. Note that I had to use underscore, because both '-' and '.' are already bound to other functions by default.
I want to repeat that if you use HDTV and DataDirect, you need to run mythfilldatabase after applying this patch to fix up the freqid field for each of the channels in your database. If you use HDTV but *not* DataDirect, you now need to use the channel minor number, not the program number, after the dash in freqid.
In testing this for the past 2 weeks, my concern about adding even more delay to tuning / channel-change time for HDTV seems to have been unfounded. It's not worse than it was; as Daniel points out, the majority of the time is spent waiting for the next keyframe anyway. Therefore I don't think PID caching should be a development priority anytime soon.
Here's an updated list of what's changed:
* The DataDirect grabber now grabs the channelMinor field into its temporary tables. I also fixed a bug in the handling of fccchannelnumber.
* mythfilldatabase fills in the freqid field in the database's channel table based on the data from zap2it. For normal NTSC stations, this is the same as channel. For ATSC stations, it's "<fccchannelnumber>-<channelMinor>". For new ATSC channels, it also fills in the channel number as <channel>_<channelMinor>.
* hdtvrecorder waits for a TVCT (Terrestrial Virtual Channel Table) and uses it to fill in the desired program, rather than taking the desired program directly from the database. This is progress, because (a) the subchannel (minor channel) is user-visible in "normal" HDTV tuners and the program number is not, (b) we can get this number from zap2it (and can't get the program number), and (c) stations can change their program numbers without notice.
* a few edits to make Daniel's FAKE_VIDEO support possible to use on a system without a tuner card at all
* a few tabs-to-spaces conversions
* Underscore is now an allowed character in channel numbers. Turns out this change was more like 18 lines in 2 files; it should have been 3 lines, but TV::ChannelKey() had a slightly bizarre interface.
These patches are against CVS as of today, though I admit my testing has been with Daniel's and John's patches applied. Fortunately, the three patches don't seem to stomp on one another much at all. If you're running CVS for HDTV, I'd strongly encourage applying all three.
-Doug
subchannel-from-dd-2.patch.bz2
Description: application/bzip
Description: OpenPGP digital signature_______________________________________________ mythtv-dev mailing list mythtv-dev@mythtv.org http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
