Re: [mythtv-users] "This is close to an existing cut point" -> missing option

[Wendy Seltzer]

Try this patch (against svn 8386).  The OSD popup seems only to allow four items (at least without digging deeper into the theme files), but since you can use ESC to cancel, it doesn't seem much of a loss to do away with the "Cancel" button from the "close to an existing cutpoint" popup.

(Since mpeg4-mpeg4 transcoding is still broken for me, I can't tell how it handles the cutpoints, but at least it lets you place them...)

--Wendy

On 12/28/05, Jeff Simpson <[EMAIL PROTECTED]> wrote:

On 12/28/05, Wendy Seltzer <[EMAIL PROTECTED]> wrote:

On 12/28/05, Jeff Simpson <[EMAIL PROTECTED]> wrote:

What I wanted to do was "place a cutpoint here anyway" since the video I was cropping to was only 5-10 seconds long for parts. Does that option make sense to add?

I'd like to see that option too.  If no one else picks it up, I'll take a look at the code.

--Wendy

I just tried to get around it by manually cropping the video with avidemux2, but that seems to change the format somehow to make it not work in dvd / vcd making programs (dvdauthor, dvdstyler, vcdimager, etc). it's not something I would often use, but it would make sense to have it there for the power users (since it's really only the power users would would be using the edit cutpoint feature at all, really)

 - jeff
 

--
Wendy Seltzer
http://wendy.seltzer.org/blog/
_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users

_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users

--
Wendy Seltzer
http://wendy.seltzer.org/blog/

Index: libs/libmythtv/NuppelVideoPlayer.h
===================================================================
--- libs/libmythtv/NuppelVideoPlayer.h	(revision 8386)
+++ libs/libmythtv/NuppelVideoPlayer.h	(working copy)
@@ -328,7 +328,7 @@
     void SetCommBreakIter(void);
 
     void HandleArbSeek(bool right);
-    void HandleSelect(void);
+    void HandleSelect(bool selectnear);
     void HandleResponse(void);
 
     void UpdateTimeDisplay(void);
Index: libs/libmythtv/NuppelVideoPlayer.cpp
===================================================================
--- libs/libmythtv/NuppelVideoPlayer.cpp	(revision 8386)
+++ libs/libmythtv/NuppelVideoPlayer.cpp	(working copy)
@@ -3226,7 +3226,7 @@
         handled = true;
 
         if (action == "SELECT")
-            HandleSelect();
+            HandleSelect(false);
         else if (action == "LEFT")
         {
             if (seekamount > 0)
@@ -3456,7 +3456,7 @@
     osd->SetText("editmode", infoMap, -1);
 }
 
-void NuppelVideoPlayer::HandleSelect(void)
+void NuppelVideoPlayer::HandleSelect(bool selectnear)
 {
     bool deletepoint = false;
     QMap<long long, int>::Iterator i;
@@ -3467,7 +3467,7 @@
         long long pos = framesPlayed - i.key();
         if (pos < 0)
             pos = 0 - pos;
-        if (pos < (int)ceil(20 * video_frame_rate))
+        if ((pos < (int)ceil(20 * video_frame_rate)) && !selectnear)
         {
             deletepoint = true;
             deleteframe = i.key();
@@ -3487,7 +3487,8 @@
             option3 += QObject::tr("right");
         else
             option3 += QObject::tr("left");
-        QString option4 = QObject::tr("Cancel");
+	QString option4 = QObject::tr("Insert new cut point");
+	//	QString option5 = QObject::tr("Cancel");
 
         dialogname = "deletemark";
         dialogtype = 0;
@@ -3497,6 +3498,7 @@
         options += option2;
         options += option3;
         options += option4;
+	//options += option5;
 
         osd->NewDialogBox(dialogname, message, options, -1);
     }
@@ -3539,6 +3541,9 @@
             case 3:
                 ReverseMark(deleteframe);
                 break;
+	    case 4:
+	         HandleSelect(true);
+		break;
             default:
                 break;
         }


_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users