I'm not sure, but the MoveTask looks like it may been to be fixed up as well. I think a unit test needs to be written to see if the functionality is correct (the current one succeeds, but I think it only tests a small part of the functionality).
I'm thinking about working on optimizing the directory scanner - I think that's where my builds are spending most of their time. I'd like to at least reduce the number of directories scanned each time a fileset is used.
Ian MacLean wrote:
Matthew,
I applied your patches to Fileset.cs and directoryscanner.cs as well as the new copytest.cs. The part of the patch fixing copy and delete failed to apply against my tree - maybe because the patch isn't in -u format.
The following patch fixes directories getting treated as files in a FileSet. This behaviour was breaking certain copy operations. It also fixes the Delete and Copy tasks to handle the new behaviour, allows delete and copy tasks to handle read-only files, adds a CopyTest unit test, and enhances the DeleteTest unit test.
All the unit tests run. There *may* be some other tasks that rely on the current broken behaviour (ie: expecting directories to appear in the FileNames collection). These tasks should be changed to use the FileSet.DirectoryNames collection as well as FileSet.FileNames.
As far as I know - only the cppTasks were expecting this. I've fixed them to work with the new behaviour.
Ian
-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger for complex code. Debugging C/C++ programs can leave you feeling lost and disoriented. TotalView can help you find your way. Available on major UNIX and Linux platforms. Try it free. www.etnus.com
_______________________________________________
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger for complex code. Debugging C/C++ programs can leave you feeling lost and disoriented. TotalView can help you find your way. Available on major UNIX and Linux platforms. Try it free. www.etnus.com
_______________________________________________
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
