Personally I think it's a bad idea to have extensions like this because they change semantics of <solution> task from something very simple (do it like VS.NET does) to something quite difficult to follow.
I've made a quick scan through all csc.exe options that cannot be set in VS.NET by searching through MSDN for "This compiler option is unavailable in Visual Studio.". And I see only four options that might be useful to add this way: /utf8output /noconfig /codepage /fullpaths any other options (there are 14 which aren't settable through VS.NET) don't make sense since they would change the semantics of the build or aren't usable with NAnt. I vote against the patch. Martin, if you have problems with the codepage - use UTF-8 for source files or change your system locale. The best way would be to move all language-specific elements to a separate resource XML file (*.resx) because XML files preserve encoding informations. To save your file as UTF-8: VS.NET => File => Advanced Save Options => Encoding => Unicode (UTF-8 with signature) Jarek ----- Original Message ----- From: "Gert Driesen" <[EMAIL PROTECTED]> To: "Martin Aliger" <[EMAIL PROTECTED]>; "! nant" <[EMAIL PROTECTED]> Sent: Friday, September 12, 2003 2:19 PM Subject: Re: [nant-dev] solution task addin > I'll commit it later today. > > Thanks, > > Gert > > ----- Original Message ----- > From: "Martin Aliger" <[EMAIL PROTECTED]> > To: "! nant" <[EMAIL PROTECTED]> > Sent: Friday, September 12, 2003 2:04 PM > Subject: Re: [nant-dev] solution task addin > > > > Here it is reworked. Looks much nicer now :) > > > > > > <solution configuration="Release" outputdir="${output.dir}" > > includevsfolders="false"> > > <projects> > > <includes name="${build.dir}/**/*.csproj"/> > > </projects> > > <assemblyfolders> > > <includes name="${output.dir}"/> > > <includes name="${nunit.dir}"/> > > </assemblyfolders> > > <compilerargs> > > <arg value="/codepage:1250"/> > > </compilerargs> > > </solution> > > > > > > Martin > > > > ----- Original Message ----- > > From: "Martin Aliger" <[EMAIL PROTECTED]> > > To: "Gert Driesen" <[EMAIL PROTECTED]>; "! nant" > > <[EMAIL PROTECTED]> > > Sent: Friday, September 12, 2003 1:08 PM > > Subject: Re: [nant-dev] solution task addin > > > > > > > > use BuildElementCollection("compilerargument" or "compilerargs") > instead > > > of [BuildElementArray("arg")] > > > Ok. I'll rework it. > > > > > > > PS. can you also change your code format to use brackets on the same > > line, > > > instead of on the next line ... > > > sorry for that. I was trying hard, but we use different code convention > > here > > > (similar to VS default) to I sometimes forget it... > > > > > > > > > ----- Original Message ----- > > > From: Gert Driesen > > > To: Martin Aliger ; ! nant > > > Sent: Friday, September 12, 2003 1:08 PM > > > Subject: Re: [nant-dev] solution task addin > > > > > > > > > Look very good, but I have some remarks : > > > > > > use BuildElementCollection("compilerargument" or "compilerargs") instead > > of > > > [BuildElementArray("arg")] > > > > > > that will : > > > > > > - make it clear that those are argument that will be passed to the > > compiler > > > - allow us to use a more structured build layout > > > > > > <solution ...> > > > <projects ...> > > > ... > > > </project> > > > <compilerarguments> | <compilerargs> > > > <arg value="....." /> > > > <arg value="...." /> > > > </compilerarguments> | </compilerargs> > > > </solution> > > > > > > why not rename GetCSCArguments to GetCompilerArguments, as these > arguments > > > will also be useful for other compilers (VB.NET). > > > > > > Keep up the good work !!! > > > > > > Gert > > > > > > PS. can you also change your code format to use brackets on the same > line, > > > instead of on the next line ... > > > ----- Original Message ----- > > > From: Martin Aliger > > > To: ! nant > > > Sent: Friday, September 12, 2003 11:35 AM > > > Subject: [nant-dev] solution task addin > > > > > > > > > Hi all, > > > > > > Again, I propose an addin into solution task. It enables use of extra > > > parameters for csc task as in this case: > > > > > > <solution configuration="Release" outputdir="${output.dir}" > > > includevsfolders="false"> > > > <projects> > > > <includes name="${build.dir}/**/*.csproj"/> > > > </projects> > > > <assemblyfolders> > > > <includes name="${output.dir}"/> > > > <includes name="${nunit.dir}"/> > > > </assemblyfolders> > > > <arg value="/codepage:1250"/> > > > </solution> > > > > > > > > > adding extra /codepage:1250 to csc calls. This is needed, when .cs files > > are > > > in another codepage than ascii, unicode or utf-8. > > > > > > > > > This could be used for other switches as well! Hope you'll like it :) > > > > > > Martin > > > > > > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers > ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers