Since I'm weirdly interested in making this work right since its a C#
learning experience, if there's something in mind that you want, let me
know and I'll fix it. Perhaps return the logging to the way it was, but
keep the consistency of .Exists() etc?
~ Matthew
On Wed, 2003-10-08 at 14:18, Gert Driesen wrote:
> ----- Original Message -----
> From: "Met @ Uber" <[EMAIL PROTECTED]>
> To: "NAnt-Devel" <[EMAIL PROTECTED]>
> Sent: Wednesday, October 08, 2003 7:46 PM
> Subject: Re: [nant-dev] DeleteTask Patch
>
>
> > Where's the bug?
>
> It was a bad choice of words ... I actually just meant the fact that its a
> lot more chatty now ...
>
> Having a message in the build log for every file that's deleted regardless
> of the verbose setting is not a good idea (imagine deleting hundreds of
> files) ...
>
> Gert
>
> >
> > On Wed, 2003-10-08 at 13:40, Met @ Uber wrote:
> > > Its definitely more chatty, which I understand is not good, but its
> > > consistent. If you don't take it, you should take the rest because its
> > > a lot more consistent. I'll make the fix if you'd like, else I'll leave
> > > it alone.
> > >
> > > On Wed, 2003-10-08 at 13:27, Gert Driesen wrote:
> > > > There's still a bug in the patch, so I wouldn't commit it for now ...
> > > >
> > > > Your patch will make the delete task a lot more chatty, as it will now
> > > > output the filename of every file in the fileset even when the task is
> not
> > > > in verbose mode ...
> > > >
> > > > The reason why there was a verbose argument in the DeleteFile method
> is to
> > > > allow a different behaviour when only a single file is deleted, and
> when
> > > > multiple files are deleted (using a fileset)
> > > >
> > > > Gert
> > > >
> > > > ----- Original Message -----
> > > > From: "Met @ Uber" <[EMAIL PROTECTED]>
> > > > To: "NAnt-Devel" <[EMAIL PROTECTED]>
> > > > Sent: Wednesday, October 08, 2003 6:46 PM
> > > > Subject: Re: [nant-dev] DeleteTask Patch
> > > >
> > > >
> > > > > ...well perhaps if I have a LOT more time.
> > > > >
> > > > > ~ Matthew
> > > > >
> > > > > On Wed, 2003-10-08 at 12:13, Martin Aliger wrote:
> > > > > > I see. But verbose could be more than 'false'/'true'. 'debug' for
> > > > example.
> > > > > >
> > > > > > Verbosity is one of fields, where NAnt should be refactored IMHO.
> > > > > >
> > > > > > Martin
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > From: "Met @ Uber" <[EMAIL PROTECTED]>
> > > > > > To: "NAnt-Devel" <[EMAIL PROTECTED]>
> > > > > > Cc: "Martin Aliger" <[EMAIL PROTECTED]>
> > > > > > Sent: Wednesday, October 08, 2003 6:14 PM
> > > > > > Subject: Re: [nant-dev] DeleteTask Patch
> > > > > >
> > > > > >
> > > > > > > I was just following that because it was already in there, and
> there
> > > > was
> > > > > > > a "verbose" option in the task, so I figured that's how it was
> used.
> > > > > > >
> > > > > > > Here's the new path.
> > > > > > >
> > > > > > > On Wed, 2003-10-08 at 11:50, Martin Aliger wrote:
> > > > > > > > if (verbose) {
> > > > > > > > Log(Level.Info,
> > > > > > > > LogPrefix + "Deleting directory
> '{0}'.",
> > > > > > > > path);
> > > > > > > > }
> > > > > > > >
> > > > > > > > should be
> > > > > > > >
> > > > > > > > Log(Level.Verbose,
> > > > > > > > LogPrefix + "Deleting directory
> '{0}'.",
> > > > > > > > path);
> > > > > > > >
> > > > > > > >
> > > > > > > > Martin
> > > > > > > >
> > > > > > > > -- Original Message --
> > > > > > > > From: "Met @ Uber" <[EMAIL PROTECTED]>
> > > > > > > > To: "NAnt-Devel" <[EMAIL PROTECTED]>
> > > > > > > > Sent: Wednesday, October 08, 2003 5:26 PM
> > > > > > > > Subject: Re: [nant-dev] DeleteTask Patch
> > > > > > > >
> > > > > > > >
> > > > > > > > > Patch is attached.
> > > > > > > > >
> > > > > > > > > On Wed, 2003-10-08 at 10:48, Ian MacLean wrote:
> > > > > > > > > > Sounds useful. Post away.
> > > > > > > > > >
> > > > > > > > > > Ian
> > > > > > > > > > Met @ Uber wrote:
> > > > > > > > > >
> > > > > > > > > > >The patch I'm talking about is hardly important, its just
> a
> > > > cleanup
> > > > > > of
> > > > > > > > > > >the logic and code within DeleteTask.cs. I was trying to
> > > > figure
> > > > > > out
> > > > > > > > why
> > > > > > > > > > >directory and file deletion were displaying different
> > > > (messages),
> > > > > > so I
> > > > > > > > > > >went in and took. I cleaned up the logic a lot so that
> > > > everything
> > > > > > is
> > > > > > > > > > >consistent, as far as I am concerned. It should be more
> > > > efficient
> > > > > > as a
> > > > > > > > > > >result.
> > > > > > > > > > >
> > > > > > > > > > >If you want it, let me know, else I'll suck it up ;-)
> > > > > > > > > > >
> > > > > > > > > > >~ Matthew
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >--
> > > > > > > > > > >This sf.net email is sponsored by:ThinkGeek
> > > > > > > > > > >Welcome to geek heaven.
> > > > > > > > > > >http://thinkgeek.com/sf
> > > > > > > > > > >_______________________________________________
> > > > > > > > > > >nant-developers mailing list
> > > > > > > > > > >[EMAIL PROTECTED]
> > > > > > > > > >
> >https://lists.sourceforge.net/lists/listinfo/nant-developers
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > This SF.net email is sponsored by: SF.net Giveback Program.
> > > > > > > > SourceForge.net hosts over 70,000 Open Source Projects.
> > > > > > > > See the people who have HELPED US provide better services:
> > > > > > > > Click here: http://sourceforge.net/supporters.php
> > > > > > > > _______________________________________________
> > > > > > > > nant-developers mailing list
> > > > > > > > [EMAIL PROTECTED]
> > > > > > > > https://lists.sourceforge.net/lists/listinfo/nant-developers
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > -------------------------------------------------------
> > > > > This SF.net email is sponsored by: SF.net Giveback Program.
> > > > > SourceForge.net hosts over 70,000 Open Source Projects.
> > > > > See the people who have HELPED US provide better services:
> > > > > Click here: http://sourceforge.net/supporters.php
> > > > > _______________________________________________
> > > > > nant-developers mailing list
> > > > > [EMAIL PROTECTED]
> > > > > https://lists.sourceforge.net/lists/listinfo/nant-developers
> > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.net email is sponsored by: SF.net Giveback Program.
> > > SourceForge.net hosts over 70,000 Open Source Projects.
> > > See the people who have HELPED US provide better services:
> > > Click here: http://sourceforge.net/supporters.php
> > > _______________________________________________
> > > nant-developers mailing list
> > > [EMAIL PROTECTED]
> > > https://lists.sourceforge.net/lists/listinfo/nant-developers
> >
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: SF.net Giveback Program.
> > SourceForge.net hosts over 70,000 Open Source Projects.
> > See the people who have HELPED US provide better services:
> > Click here: http://sourceforge.net/supporters.php
> > _______________________________________________
> > nant-developers mailing list
> > [EMAIL PROTECTED]
> > https://lists.sourceforge.net/lists/listinfo/nant-developers
> >
> >
>
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
