RE: [nant-dev] AsmInfo patch

[Kevin Miller]

Title: RE: [nant-dev] AsmInfo patch

Funny, oh well it was fun getting my hands dirty with NAnt stuff again.

I say use my implementation :)  Hmm, Not sure what which would be better.

I don't understand the importance of the 1.0 vs 1.1 comment differences when the file generated will not have any comments. Unless I missed out on a feature of asminfo that allows those comments to be retained.

I say if the comment feature is not explicitly necessary and the performance of hashing is better than line by line compare which is anyones guess (my gut tells my the line by line may be better) that we use the hash based method.

Honestly I do not care too much either way as long as the feature makes it into NAnt :)

Kevin

-----Original Message-----
From: Gert Driesen [mailto:[EMAIL PROTECTED]]
Sent: Sat 2/28/2004 2:01 AM
To: Kevin Miller; [EMAIL PROTECTED]
Subject: Re: [nant-dev] AsmInfo patch

Hi Kevin,

I just added support for this to the <asminfo> task in cvs yesterday :(

I actually compared each line of both files and skipped all comments ... I
did this as files generated with .NET 1.0 or .NET 1.1 only differ in the
comment block that is insert into the generated file :

//--------------------------------------------------------------------------
----
// <autogenerated>
//     This code was generated by a tool.
//     Runtime Version: 1.1.4322.940
//
//     Changes to this file may cause incorrect behavior and will be lost if
//     the code is regenerated.
// </autogenerated>
//--------------------------------------------------------------------------
----

However, I do like your approach a lot better.  So, I'm not sure if I should
keep the current (quick and dirty) implementation or use yours ...

What do you think ?

Gert

----- Original Message -----
From: "Kevin Miller" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, February 27, 2004 9:24 PM
Subject: [nant-dev] AsmInfo patch


I found the asminfo task today and fell in love. It solved a few
problems I was having with signing assemblies and paths to the key file.
I was frustrated by the fact that it always generates the
AssemblyInfo.cs file even if there are no changes. This causes the
csc/vbc task to build the project even if only the AssemblyInfo class
has been updated. This is clearly an annoyance during development
builds.

Attached is an updated  that compares the present AssemblyInfo.<x> to
the one being generated. If they are different it writes the new code
one out to disk.

This file is updating the .84 release. Sorry I did not compare to the
latest cvs. Also, I did not add a switch to make this behavior optional.
This post is just to feel out well this enhancement would be received. I
am willing to create a decent patch. Let me know if there is interest in
this feature.

Kevin Miller