Gert Driesen wrote:
I disagree - this goes against how every other open source project packages their distribution.Ian,
After giving it some more thought, I think the "install" target of the makefile should install the pre-built binaries and docs for official NAnt distributions, not and rebuild the binaries from source. We went to a lot of trouble in order to have a single binary distribution, and I'd hate to see all that effort go to waste.
As I said before - its a source distribution that happens to include pre built binaries *not* a binary distribution. Our install instructions have always been pretty unclear which is why users almost *always* try to build after downloading nant. I think we need a seperate binary *only* distribution with a simple install script ( not makefile ).
For users building NAnt from cvs, the "install" target of the make file should ofcourse build NAnt, and install the freshly built binaries (and docs).I would suggest that an 'install' of a binary distribution be accomplished with a script rather than a makefile.
To accomplish this, we need either two different makefiles or a single makefile which we adjust during packaging using the replacetokens or replacestring filters. How would you go about this ?
Also, the install targets in the NAnt build file should no longer depend on other build/doc targets (but they should just install whatever files are available in ${build.dir} (limited to bin, doc and examples directories). The dependency on other NAnt build target should be taken care of in the makefile.why is that ? sure you'd want to install somthing thats built -- isn't that the point ? if you do a make install with most OSS projects it will build first if its not up to date. Why should the dependency happen in the makefile ? Lets use NAnt for this - its a build tool and it handle dependencies fine.
For building from cvs, our make file would have these install targets:
install:
if test x$(OS) = xWindows_NT; then make install-windows; else make install-linux; fi
install-windows: $(NANT) -f:NAnt.build package install-windows -D:install.prefix=$(prefix)
install-linux: $(NANT) -f:NAnt.build build install-linux -D:install.prefix=$(prefix)
While the makefile for official distribution would have the following install targets (it would get the binaries/docs from the distribution itself):
install:
if test x$(OS) = xWindows_NT; then make install-windows; else make install-linux; fi
install-windows:
$(NANT) -f:NAnt.build install-windows -D:install.prefix=$(prefix) -D:build.dir=.
install-linux:
$(NANT) -f:NAnt.build install-linux -D:install.prefix=$(prefix) -D:build.dir=.
What do you think about this ?
I think its very confusing to have 2 seperate makefiles depending on how you obtained the source tree. Whether I obtained the package via download or from cvs I would expect that the Makefile in the same position in the source tree would do the same thing. And whenever I download a package with a make file I expect
Make install
to build it not just copy some files.
my proposal - 2 download packages:
1) binaries only with a simple shell script to install on linux, batch file for windows -- hopefully installer at some stage.
2) source package that mirrors the cvs tree. Use Make install to build install on *nix, bin\NAnt.exe install to build install on windows.
This is a fairly standard packaging practice - getting clever with multiple Makefiles seems like a recipe for confision.
Ian
------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
