Your changes are fine with me. I wanted to do the same thing, but was too shy to create the enums because it was a breaking change.
I have attached my unit tests that I modified to run against the code. Use them if you want. Thanks for you help. Looking forward to rc2 or final release. Jason >-----Original Message----- >From: Gert Driesen [mailto:[EMAIL PROTECTED] >Sent: Thursday, December 30, 2004 10:14 AM >To: Morris, Jason; nant-developers@lists.sourceforge.net >Subject: RE: [nant-dev] Request for version task patch be >committed (#1083618) > >Hi Jason, > >I've attached a modified version of the <version> task, which >contains part of your changes but uses enums for BuildType and >RevisionType (making it a breaking change). > >Let me know if you think its ok. > >Gert > >> -----Original Message----- >> From: [EMAIL PROTECTED] >> [mailto:[EMAIL PROTECTED] On Behalf Of >> Morris, Jason >> Sent: donderdag 30 december 2004 7:39 >> To: nant-developers@lists.sourceforge.net >> Subject: RE: [nant-dev] Request for version task patch be committed >> (#1083618) >> >> Has any committers had a chance to look at this yet? Is there >> something wrong that is preventing the patch to be >committed. If so, >> please let me know so that I can correct them. I would really like >> the changes to be in the .85 release of nant/nantcontrib. >> >> Jason >> >> >-----Original Message----- >> >From: [EMAIL PROTECTED] >> >[mailto:[EMAIL PROTECTED] On Behalf Of >> >Morris, Jason >> >Sent: Monday, December 20, 2004 8:25 AM >> >To: nant-developers@lists.sourceforge.net >> >Subject: RE: [nant-dev] Request for version task patch be committed >> >(#1083618) >> > >> >Nant or nantcontrib developers, >> > >> >I know that recent work is focused on getting .85 out the door, but >> >if anyone could commit this patch, I would be much appreciated. I >> >know that it isn't much of a patch. >> > >> >Also, the patch was submitted to the nant patches instead of the >> >nantcontrib patches...sorry. >> > >> >Jason >> > >> >>-----Original Message----- >> >>From: [EMAIL PROTECTED] >> >>[mailto:[EMAIL PROTECTED] On Behalf Of >> >>Morris, Jason >> >>Sent: Saturday, December 11, 2004 3:24 PM >> >>To: nant-developers@lists.sourceforge.net >> >>Subject: [nant-dev] Request for version task patch be committed >> >>(#1083618) >> >> >> >>Nant committers, >> >> >> >>I would like my patch (#1083618) that I submitted for the >> NAntContrib >> >><version> task be applied before the 0.85 release. >> >> I mistakenly submitted the patch to the Nant patch tracker >> >instead of >> >>the NAntContrib patch tracker. >> >> >> >>The patch was to correct confusion that I and others on >the mailing >> >>list had with figuring out how to use the task. I hope that this >> >>improves things. Also, the patch contains the following changes: >> >> >> >>* Improved in-code documentation to avoid confusion that has been >> >>expressed on the mailing list. >> >>* Refactored code to remove duplication and make design simple >> >>* Added several new properties >> >> - Prefix.Major >> >> - Prefix.Minor >> >> - Prefix.Build >> >> - Prefix.Revision >> >>* Improve BuildType and RevisionType arguments >> >> - Parsing is more forgiving because values are now case >> >>insensitive. >> >> - const defined for each argument value (no more >> >duplicated string >> >>compares) >> >>* Added unit tests (separate patch) >> >> >> >>Patch was created by WinMerge which is GNU/diffutils >> compatible from >> >>version 0.85rc1 (cvs version 1.7) >> >> >> >>Please let me know if there is anything that you require before >> >>submitting this patch. >> >> >> >>Two other changes I would have made, but didn't since they >> would have >> >>introduced breaking changes. One, the path attribute should >> >be renamed >> >>to the filename as that is more appropriate description. Two, >> >startDate >> >>attribute might be renamed to startdate to maintain >> consistence with >> >>attribute naming convention. >> >> >> >>Thanks, >> >>Jason >> >> >> >> >> >>------------------------------------------------------- >> >>SF email is sponsored by - The IT Product Guide Read honest >> & candid >> >>reviews on hundreds of IT Products from real users. >> >>Discover which products truly live up to the hype. Start >> reading now. >> >>http://productguide.itmanagersjournal.com/ >> >>_______________________________________________ >> >>nant-developers mailing list >> >>nant-developers@lists.sourceforge.net >> >>https://lists.sourceforge.net/lists/listinfo/nant-developers >> >> >> > >> > >> >------------------------------------------------------- >> >SF email is sponsored by - The IT Product Guide Read honest >& candid >> >reviews on hundreds of IT Products from real users. >> >Discover which products truly live up to the hype. Start >> reading now. >> >http://productguide.itmanagersjournal.com/ >> >_______________________________________________ >> >nant-developers mailing list >> >nant-developers@lists.sourceforge.net >> >https://lists.sourceforge.net/lists/listinfo/nant-developers >> > >> >> >> ------------------------------------------------------- >> The SF.Net email is sponsored by: Beat the post-holiday blues Get a >> FREE limited edition SourceForge.net t-shirt from ThinkGeek. >> It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >> _______________________________________________ >> nant-developers mailing list >> nant-developers@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/nant-developers >> >> >
VersionTaskTests.cs
Description: VersionTaskTests.cs
