Bugs item #1169601, was opened at 2005-03-23 19:53 Message generated for change (Comment added) made by jkordas You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=402868&aid=1169601&group_id=31650
Category: Tasks Group: 0.85 Status: Closed Resolution: Fixed Priority: 5 Submitted By: Jack (jkordas) Assigned to: Gert Driesen (drieseng) Summary: exception from commented-out include file Initial Comment: This is in the nightly build, nant-0.85-nightly-2005-03-23. If you have a line in a .cpp file such as //#include "foo/bar.h" and foo.bar.h does not exist, you get an error compiling when nothing should happen because of the comment. Problem is in NAnt.VisualCpp.Tasks.ClTasks.FindUpdatedInclude() _includeRegex must not be screening out the above. If I change this to //#include "bar.h" I don't see this problem. ---------------------------------------------------------------------- >Comment By: Jack (jkordas) Date: 2005-03-25 12:49 Message: Logged In: YES user_id=1230267 Sorry about that. It does look like both cases are now handled. Thanks for the responsiveness. I'll try to upload the repo again just for completeness. ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2005-03-24 12:50 Message: Logged In: YES user_id=707851 Jack, you forgot to upload (or made a mistake) the repro, but I was not able to reproduce any of the issues you mentioned with my fix. I'm gonna close this bug report now, but don't hesitate to reopen it if you still have problems with the next nightly build. Thanks for the report ! ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2005-03-24 10:58 Message: Logged In: YES user_id=707851 Thanks for the repro. I already fixed this issue in CVS (not sure about the second one, but I'll test it when I get home). I'll upload a new nightly build later today (http://nant.sourceforge.net/nightly/latest). ---------------------------------------------------------------------- Comment By: Jack (jkordas) Date: 2005-03-24 10:43 Message: Logged In: YES user_id=1230267 I added a repro. The sample as sent compiles. To activate each bug you will need to add a '#' in front of the include in either Form1.cpp or Common\Nested.cpp There are two somewhat related problems. The first one described initially results in an exception such as the following. Unexpected error while compiling project 'WinForms' Could not find a part of the path "D:\Program Files\Microsoft Visual Studio.NET 2003\VC7 \ATLMFC\INCLUDE\foo". The second results in an exception as follows. BUILD FAILED Unexpected error while compiling project 'WinForms' Search pattern cannot contain ".." to move up directories and can be contained only internally in file/directory names, as in "a..b". ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2005-03-24 00:38 Message: Logged In: YES user_id=707851 Nevermind, I found the cause. ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2005-03-24 00:20 Message: Logged In: YES user_id=707851 I agree that we should be screening out commented includes, but I don't see what exception you'd get from the example you provided. Can you provide more information on that ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=402868&aid=1169601&group_id=31650 ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
